From d9070835c51c0697e4d3ffdeaba09ce39323f674 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Tue, 30 Jun 2026 21:32:12 +0200 Subject: [PATCH] extensionSystem: Clarify what the extension disable function does Part-of: (cherry picked from commit f10dcaac409ea87c1577e7df4fccdf16a3768597) --- js/ui/extensionSystem.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js index 8a10c5c5b..fcff08eb4 100644 --- a/js/ui/extensionSystem.js +++ b/js/ui/extensionSystem.js @@ -115,7 +115,7 @@ export class ExtensionManager extends Signals.EventEmitter { this._unloadExtensionStylesheet(ext); this._loadExtensionStylesheet(ext); } catch (e) { - this._callExtensionDisable(ext.uuid); + this._callExtensionDisableWithRebase(ext.uuid); this.logExtensionError(ext.uuid, e); } } @@ -180,7 +180,7 @@ export class ExtensionManager extends Signals.EventEmitter { return false; } - async _callExtensionDisable(uuid) { + async _callExtensionDisableWithRebase(uuid) { const extension = this.lookup(uuid); if (!extension) return; @@ -448,7 +448,7 @@ export class ExtensionManager extends Signals.EventEmitter { // Try to disable it -- if it's ERROR'd, we can't guarantee that, // but it will be removed on next reboot, and hopefully nothing // broke too much. - await this._callExtensionDisable(uuid); + await this._callExtensionDisableWithRebase(uuid); this._changeExtensionState(extension, ExtensionState.UNINSTALLED); @@ -580,7 +580,7 @@ export class ExtensionManager extends Signals.EventEmitter { for (const uuid of extensionsToDisable) { // eslint-disable-next-line no-await-in-loop - await this._callExtensionDisable(uuid); + await this._callExtensionDisableWithRebase(uuid); } // Find and enable all the newly enabled extensions: UUIDs found in the @@ -775,7 +775,7 @@ export class ExtensionManager extends Signals.EventEmitter { for (const uuid of extensionsToDisable) { // eslint-disable-next-line no-await-in-loop - await this._callExtensionDisable(uuid); + await this._callExtensionDisableWithRebase(uuid); } } -- 2.39.5